Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for audio tags #36

Merged
3 commits merged into from
Jun 25, 2016
Merged

Add support for audio tags #36

3 commits merged into from
Jun 25, 2016

Conversation

cvn
Copy link
Contributor

@cvn cvn commented Jun 25, 2016

This adds support for using the vjs-video and vjs-video-container directives with audio tags. Video.js has supported audio tags since v4.9.

Let me know if there's anything you'd like me to change.

@cvn
Copy link
Contributor Author

cvn commented Jun 25, 2016

@LonnyGomes can you look at this audio tag PR soon?

@ghost
Copy link

ghost commented Jun 25, 2016

@cvn This is GREAT!! Thanks for adding the unit test as well. I'll probably add just an example of using audio to the vjs-video landing page and push out a new release!

@ghost ghost merged commit d1e2ac5 into LonnyGomes:master Jun 25, 2016
@ghost
Copy link

ghost commented Jun 26, 2016

@cvn merged and added to the v0.1.6 release

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant